Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knative website design issues fixed #5984

Closed
wants to merge 2 commits into from
Closed

Knative website design issues fixed #5984

wants to merge 2 commits into from

Conversation

nafisreza
Copy link

"Implemented website redesign according to issue #134 of knative/ux"
I have set up the project locally on my machine and started making improvements according to provided design.

Proposed Changes

  • Website color theme updated along with hover color/animation.
  • Right nav buttons are aligned with github logo and top border rounded.
  • Buttons are rounder with increased border radius.
  • Gap between two CTAs added.
  • SVG icons color updated according to new theme.
  • Font weights of all the content updated according to provided design.
  • In Knative components, text are aligned center.
  • Background color of 'Case Studies' changed along with the cards, necessary gap added and hover animation added.
  • Footer has 3 column spacing and font weight adjusted.
  • Social icons colors changed from gray to white..
  • Back to the top button border radius and box shadow updated
  • A few texts were broken down with
    tags, removed them to make texts single-lined.

Preview:

screencapture-127-0-0-1-8000-docs-2024-05-22-07_03_51

@knative-prow Knative Prow
Copy link

knative-prow bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nafisreza
Once this PR has been reviewed and has the lgtm label, please assign krsna-m for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from skonto and snneji May 22, 2024 01:10
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 22, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow Knative Prow
Copy link

knative-prow bot commented May 22, 2024

Welcome @nafisreza! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 22, 2024
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 662d0ed
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/664d460026d23b0008f796b1
😎 Deploy Preview https://deploy-preview-5984--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliok
Copy link
Member

aliok commented May 23, 2024

hey @nafisreza

This task is part of LFX mentorship project. If you're interested in participating in that program, I would recommend working on your proposal instead of working on the actual task.

Thanks for your contribution!
I will keep this PR on hold as I want to spend time on reviewing LFX mentee's PR.

@aliok
Copy link
Member

aliok commented May 23, 2024

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@nafisreza
Copy link
Author

Thanks @aliok for the reply.
I have already submitted my proposal on LFX portal along with the necessary docs. Fingers crossed! :)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
@github-actions github-actions bot closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skonto skonto Awaiting requested review from skonto

@snneji snneji Awaiting requested review from snneji

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nafisreza @aliok @knative-prow-robot